v1.3.0: Bedrock translator refactor, usage metrics, session restore fixes, and predefined rules

Major changes: - **Bedrock translator architecture**: Extract orchestration logic from `impl.rs` into a dedicated `translator.rs` module. Rename `convert_request.rs` → `request_translator.rs` and `stream.rs` → `response_translator.rs` for clarity. Remove `tool_docs.rs` (inlined). Remove `fallback_to_warp` setting and server fallback path — Bedrock is now the sole backend. - **Unknown tool handling**: The response translator now detects hallucinated/unknown tool calls from the model and synthesizes error tool_results so the conversation doesn't deadlock waiting for a result that will never come. - **Usage display overhaul**: Replace credit-based usage display with detailed token metrics showing context window %, cache hit rate (read/write/miss), and estimated cost in dollars. Add `total_input_tokens`, `total_cache_read_tokens`, `total_cache_write_tokens`, and `cache_miss_tokens` accessors to `AIConversation`. - **Predefined rules system**: Add `predefined_rules.rs` with 11 system-defined behavioral rules that are auto-seeded on first launch. Add "Add Predefined Rules" button to the Rules UI for re-adding them later. Track seeding state via `has_seeded_predefined_rules` setting. - **Session restore improvements**: Rename database file from `warp.sqlite` to `galaxy.sqlite` with automatic migration from both same-directory and state_dir legacy paths. Improve CWD persistence by falling back to `session_startup_path` for agent-mode and fresh tabs. Add extensive session-save/restore logging. - **Shell bootstrap rebrand**: Rename `WARP_INITIAL_WORKING_DIR` environment variable to `GALAXY_INITIAL_WORKING_DIR` across bash, zsh, and fish bootstrap scripts. - **Model defaults**: Change default Bedrock model from Opus 4.7 to Opus 4.6. Add `context_window_for_model()` helper with model-aware context sizes. Remove `is_bedrock_model()` (no longer needed without server fallback). - **User query persistence**: The response translator now emits a `UserQuery` proto message at stream start so the user's prompt persists across sessions for conversation titles. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-05-20 15:15:28 -05:00
parent ec99146ccc
commit eaa2ddc75e
38 changed files with 1687 additions and 1129 deletions
@@ -0,0 +1,185 @@
+use warp_multi_agent_api::{self as api, response_event::stream_finished};
+
+use super::response_translator::*;
+
+#[test]
+fn test_build_stream_init_has_valid_ids() {
+    let event = build_stream_init("req-123", "conv-456");
+
+    match event.r#type {
+        Some(api::response_event::Type::Init(init)) => {
+            assert_eq!(init.request_id, "req-123");
+            assert_eq!(init.conversation_id, "conv-456");
+            assert_eq!(init.run_id, "");
+        }
+        other => panic!("Expected Init event, got {:?}", other),
+    }
+}
+
+#[test]
+fn test_build_stream_finished_done_reason() {
+    let reason = stream_finished::Reason::Done(stream_finished::Done {});
+    let event = build_stream_finished(reason, 100, 50, 20, 10, "anthropic.claude-sonnet-4-6");
+
+    match event.r#type {
+        Some(api::response_event::Type::Finished(finished)) => {
+            assert!(matches!(
+                finished.reason,
+                Some(stream_finished::Reason::Done(_))
+            ));
+            assert!(!finished.should_refresh_model_config);
+            let metadata = finished.conversation_usage_metadata.unwrap();
+            assert_eq!(
+                metadata
+                    .byok_token_usage
+                    .get("bedrock")
+                    .unwrap()
+                    .total_tokens,
+                180
+            );
+            // Verify token_usage includes cache breakdown
+            assert_eq!(finished.token_usage.len(), 1);
+            let usage = &finished.token_usage[0];
+            assert_eq!(usage.total_input, 100);
+            assert_eq!(usage.output, 50);
+            assert_eq!(usage.input_cache_read, 20);
+            assert_eq!(usage.input_cache_write, 10);
+            assert!(usage.cost_in_cents > 0.0);
+        }
+        other => panic!("Expected Finished event, got {:?}", other),
+    }
+}
+
+#[test]
+fn test_build_stream_finished_max_token_limit() {
+    let reason = stream_finished::Reason::MaxTokenLimit(stream_finished::ReachedMaxTokenLimit {});
+    let event = build_stream_finished(reason, 200, 100, 0, 0, "anthropic.claude-sonnet-4-6");
+
+    match event.r#type {
+        Some(api::response_event::Type::Finished(finished)) => {
+            assert!(matches!(
+                finished.reason,
+                Some(stream_finished::Reason::MaxTokenLimit(_))
+            ));
+        }
+        other => panic!("Expected Finished event, got {:?}", other),
+    }
+}
+
+#[test]
+fn test_build_stream_finished_other_reason() {
+    let reason = stream_finished::Reason::Other(stream_finished::Other {});
+    let event = build_stream_finished(reason, 0, 0, 0, 0, "anthropic.claude-sonnet-4-6");
+
+    match event.r#type {
+        Some(api::response_event::Type::Finished(finished)) => {
+            assert!(matches!(
+                finished.reason,
+                Some(stream_finished::Reason::Other(_))
+            ));
+        }
+        other => panic!("Expected Finished event, got {:?}", other),
+    }
+}
+
+#[test]
+fn test_build_create_task_event() {
+    let event = super::response_translator::build_create_task("task-abc-123");
+
+    match event.r#type {
+        Some(api::response_event::Type::ClientActions(actions)) => {
+            assert_eq!(actions.actions.len(), 1);
+            match &actions.actions[0].action {
+                Some(api::client_action::Action::CreateTask(create)) => {
+                    let task = create.task.as_ref().unwrap();
+                    assert_eq!(task.id, "task-abc-123");
+                    assert!(task.messages.is_empty());
+                    assert!(task.description.is_empty());
+                    assert!(task.dependencies.is_none());
+                }
+                other => panic!("Expected CreateTask action, got {:?}", other),
+            }
+        }
+        other => panic!("Expected ClientActions event, got {:?}", other),
+    }
+}
+
+#[test]
+fn test_build_create_task_has_no_parent() {
+    let event = super::response_translator::build_create_task("root-task-id");
+
+    if let Some(api::response_event::Type::ClientActions(actions)) = event.r#type {
+        if let Some(api::client_action::Action::CreateTask(create)) = &actions.actions[0].action {
+            let task = create.task.as_ref().unwrap();
+            assert!(
+                task.dependencies.is_none(),
+                "Root task CreateTask must have no dependencies (no parent_id)"
+            );
+        }
+    }
+}
+
+#[test]
+fn test_context_window_for_model_1m_marker() {
+    assert_eq!(context_window_for_model("anthropic.claude-opus-4-6[1m]"), 1_000_000);
+    assert_eq!(context_window_for_model("us.anthropic.claude-opus-4-6[1M]"), 1_000_000);
+    assert_eq!(context_window_for_model("anthropic.claude-sonnet-4-6[1m]"), 1_000_000);
+}
+
+#[test]
+fn test_context_window_for_model_standard_claude() {
+    assert_eq!(context_window_for_model("anthropic.claude-opus-4-6"), 200_000);
+    assert_eq!(context_window_for_model("us.anthropic.claude-sonnet-4-6"), 200_000);
+    assert_eq!(context_window_for_model("anthropic.claude-haiku-4-5-20251001-v1:0"), 200_000);
+}
+
+#[test]
+fn test_context_window_for_model_nova() {
+    assert_eq!(context_window_for_model("amazon.nova-pro-v1:0"), 300_000);
+    assert_eq!(context_window_for_model("amazon.nova-lite-v1:0"), 300_000);
+    assert_eq!(context_window_for_model("amazon.nova-micro-v1:0"), 300_000);
+}
+
+#[test]
+fn test_context_window_for_model_deepseek() {
+    assert_eq!(context_window_for_model("deepseek.r1-v1:0"), 128_000);
+}
+
+#[test]
+fn test_cost_varies_by_model() {
+    let reason = stream_finished::Reason::Done(stream_finished::Done {});
+    let opus_event = build_stream_finished(reason.clone(), 1000, 1000, 0, 0, "anthropic.claude-opus-4-6");
+    let reason = stream_finished::Reason::Done(stream_finished::Done {});
+    let sonnet_event = build_stream_finished(reason.clone(), 1000, 1000, 0, 0, "anthropic.claude-sonnet-4-6");
+    let reason = stream_finished::Reason::Done(stream_finished::Done {});
+    let haiku_event = build_stream_finished(reason, 1000, 1000, 0, 0, "anthropic.claude-haiku-4-5-20251001-v1:0");
+
+    let opus_cost = match opus_event.r#type {
+        Some(api::response_event::Type::Finished(f)) => f.token_usage[0].cost_in_cents,
+        _ => panic!("Expected Finished"),
+    };
+    let sonnet_cost = match sonnet_event.r#type {
+        Some(api::response_event::Type::Finished(f)) => f.token_usage[0].cost_in_cents,
+        _ => panic!("Expected Finished"),
+    };
+    let haiku_cost = match haiku_event.r#type {
+        Some(api::response_event::Type::Finished(f)) => f.token_usage[0].cost_in_cents,
+        _ => panic!("Expected Finished"),
+    };
+
+    assert!(opus_cost > sonnet_cost, "Opus should cost more than Sonnet");
+    assert!(sonnet_cost > haiku_cost, "Sonnet should cost more than Haiku");
+    assert!(haiku_cost > 0.0, "All costs should be positive for non-zero tokens");
+}
+
+#[test]
+fn test_cost_zero_for_zero_tokens() {
+    let reason = stream_finished::Reason::Done(stream_finished::Done {});
+    let event = build_stream_finished(reason, 0, 0, 0, 0, "anthropic.claude-sonnet-4-6");
+
+    let cost = match event.r#type {
+        Some(api::response_event::Type::Finished(f)) => f.token_usage[0].cost_in_cents,
+        _ => panic!("Expected Finished"),
+    };
+    assert_eq!(cost, 0.0);
+}