Fix all 109 warnings: suppress dead code in removed feature files, clean unused imports

This commit is contained in:
Ryan Ward
2026-05-12 09:05:47 -05:00
parent 2c651f2085
commit c2c6b3bc8a
20 changed files with 22 additions and 9 deletions
+1 -1
View File
@@ -59,7 +59,7 @@ pub async fn generate_multi_agent_output(
api_keys.allow_use_of_warp_credits = params.allow_use_of_warp_credits_with_byok; api_keys.allow_use_of_warp_credits = params.allow_use_of_warp_credits_with_byok;
} }
let mut request = api::Request { let request = api::Request {
task_context: Some(api::request::TaskContext { task_context: Some(api::request::TaskContext {
tasks: params.tasks, tasks: params.tasks,
}), }),
+1
View File
@@ -1,3 +1,4 @@
#![allow(dead_code, unused_imports, unused_variables, deprecated)]
use warp_multi_agent_api as api; use warp_multi_agent_api as api;
use super::convert::{ConversationMessage, ContentPart, MessageContent, MessageRole, ToolDefinition}; use super::convert::{ConversationMessage, ContentPart, MessageContent, MessageRole, ToolDefinition};
@@ -1,3 +1,4 @@
#![allow(dead_code, unused_imports, unused_variables)]
use itertools::Itertools as _; use itertools::Itertools as _;
use markdown_parser::{parse_markdown, FormattedText, FormattedTextFragment, FormattedTextLine}; use markdown_parser::{parse_markdown, FormattedText, FormattedTextFragment, FormattedTextLine};
use parking_lot::FairMutex; use parking_lot::FairMutex;
+1
View File
@@ -1,3 +1,4 @@
#![allow(dead_code, unused_imports, unused_variables)]
use crate::ai::agent::conversation::AIConversationId; use crate::ai::agent::conversation::AIConversationId;
use crate::ai::agent::AIAgentExchangeId; use crate::ai::agent::AIAgentExchangeId;
use crate::auth::AuthStateProvider; use crate::auth::AuthStateProvider;
+1
View File
@@ -1,3 +1,4 @@
#![allow(dead_code, unused_imports, unused_variables)]
mod changelog; mod changelog;
mod channel_versions; mod channel_versions;
#[cfg(target_os = "linux")] #[cfg(target_os = "linux")]
@@ -1,3 +1,4 @@
#![allow(dead_code, unused_imports, unused_variables)]
use galaxyui::{ use galaxyui::{
elements::{CornerRadius, Dismiss, MouseStateHandle, Radius}, elements::{CornerRadius, Dismiss, MouseStateHandle, Radius},
fonts::Weight, fonts::Weight,
+2 -3
View File
@@ -25,7 +25,7 @@ use crate::settings::{
AgentModeCodingPermissionsType, AgentModeCommandExecutionDenylist, AgentModeCodingPermissionsType, AgentModeCommandExecutionDenylist,
AgentModeCommandExecutionPredicate, AgentModeQuerySuggestionsEnabled, BedrockAuthMethod, AgentModeCommandExecutionPredicate, AgentModeQuerySuggestionsEnabled, BedrockAuthMethod,
BedrockAutoLogin, BedrockCrossRegionInference, BedrockEnabled, BedrockFallbackToWarp, BedrockAutoLogin, BedrockCrossRegionInference, BedrockEnabled, BedrockFallbackToWarp,
CanUseWarpCreditsWithByok, CodeSettings, CodebaseContextEnabled, FileBasedMcpEnabled, CodeSettings, CodebaseContextEnabled, FileBasedMcpEnabled,
GitOperationsAutogenEnabled, IncludeAgentCommandsInHistory, IntelligentAutosuggestionsEnabled, GitOperationsAutogenEnabled, IncludeAgentCommandsInHistory, IntelligentAutosuggestionsEnabled,
MemoryEnabled, NLDInTerminalEnabled, NaturalLanguageAutosuggestionsEnabled, MemoryEnabled, NLDInTerminalEnabled, NaturalLanguageAutosuggestionsEnabled,
RuleSuggestionsEnabled, SharedBlockTitleGenerationEnabled, RuleSuggestionsEnabled, SharedBlockTitleGenerationEnabled,
@@ -40,7 +40,7 @@ use crate::view_components::{
FilterableDropdown, SubmittableTextInput, SubmittableTextInputEvent, FilterableDropdown, SubmittableTextInput, SubmittableTextInputEvent,
}; };
use crate::workspaces::user_workspaces::UserWorkspacesEvent; use crate::workspaces::user_workspaces::UserWorkspacesEvent;
use ::ai::api_keys::{ApiKeyManager, ApiKeys}; use ::ai::api_keys::ApiKeyManager;
use enum_iterator::all; use enum_iterator::all;
use itertools::Itertools; use itertools::Itertools;
use regex::Regex; use regex::Regex;
@@ -138,7 +138,6 @@ use markdown_parser::{FormattedText, FormattedTextFragment, FormattedTextLine};
use std::borrow::Cow; use std::borrow::Cow;
use std::cell::RefCell; use std::cell::RefCell;
use std::collections::HashMap; use std::collections::HashMap;
use std::ops::Not;
use std::path::{Path, PathBuf}; use std::path::{Path, PathBuf};
use std::sync::LazyLock; use std::sync::LazyLock;
+1 -3
View File
@@ -1,4 +1,3 @@
use self::telemetry::SettingsTelemetryEvent;
use crate::pane_group::focus_state::PaneFocusHandle; use crate::pane_group::focus_state::PaneFocusHandle;
use crate::server::telemetry::MCPServerCollectionPaneEntrypoint; use crate::server::telemetry::MCPServerCollectionPaneEntrypoint;
use crate::settings_view::mcp_servers_page::MCPServersSettingsPage; use crate::settings_view::mcp_servers_page::MCPServersSettingsPage;
@@ -14,7 +13,6 @@ use crate::{
pane_group::{ pane_group::{
pane::view, BackingView, Direction, PaneConfiguration, PaneEvent, SplitPaneState, pane::view, BackingView, Direction, PaneConfiguration, PaneEvent, SplitPaneState,
}, },
server::server_api::ServerApiProvider,
settings::{AISettings, BlockVisibilitySettings, SettingsFileError}, settings::{AISettings, BlockVisibilitySettings, SettingsFileError},
settings_view::mcp_servers_page::MCPServersSettingsPageEvent, settings_view::mcp_servers_page::MCPServersSettingsPageEvent,
terminal::{model::blockgrid::BlockGrid, SizeInfo}, terminal::{model::blockgrid::BlockGrid, SizeInfo},
@@ -1753,7 +1751,7 @@ impl SettingsView {
if self.settings_page(page_section).is_none() { if self.settings_page(page_section).is_none() {
return; return;
} }
let previous_section = self.current_settings_page; let _previous_section = self.current_settings_page;
ctx.enable_key_bindings_dispatching(); ctx.enable_key_bindings_dispatching();
@@ -1,3 +1,4 @@
#![allow(dead_code, unused_imports, unused_variables)]
use crate::editor::Event as EditorEvent; use crate::editor::Event as EditorEvent;
use crate::modal::{Modal, ModalViewState}; use crate::modal::{Modal, ModalViewState};
use crate::server::server_api::auth::AuthClient; use crate::server::server_api::auth::AuthClient;
+1
View File
@@ -1,3 +1,4 @@
#![allow(dead_code, unused_imports, unused_variables)]
use super::{ use super::{
platform::{ platform::{
CreateApiKeyModal, CreateApiKeyModalEvent, CreateApiKeyModalViewState, ExpireApiKeyButton, CreateApiKeyModal, CreateApiKeyModalEvent, CreateApiKeyModalViewState, ExpireApiKeyButton,
+2 -2
View File
@@ -12,7 +12,7 @@ use galaxyui::r#async::{SpawnedFutureHandle, Timer};
use regex::Regex; use regex::Regex;
use settings::Setting as _; use settings::Setting as _;
use galaxy_core::context_flag::ContextFlag; use galaxy_core::context_flag::ContextFlag;
use galaxy_core::features::FeatureFlag;
use galaxy_core::ui::theme::WarpTheme; use galaxy_core::ui::theme::WarpTheme;
use galaxyui::elements::{ use galaxyui::elements::{
Align, ChildAnchor, ChildView, ConstrainedBox, Container, CornerRadius, CrossAxisAlignment, Align, ChildAnchor, ChildView, ConstrainedBox, Container, CornerRadius, CrossAxisAlignment,
@@ -46,7 +46,7 @@ use crate::{
channel::ChannelState, channel::ChannelState,
report_if_error, send_telemetry_from_ctx, report_if_error, send_telemetry_from_ctx,
server::telemetry::TelemetryEvent, server::telemetry::TelemetryEvent,
settings::{AISettings, PrivacySettings}, settings::PrivacySettings,
terminal::safe_mode_settings::{SafeModeEnabled, SafeModeSettings}, terminal::safe_mode_settings::{SafeModeEnabled, SafeModeSettings},
ui_components::icons::Icon, ui_components::icons::Icon,
workspaces::{ workspaces::{
@@ -1,3 +1,4 @@
#![allow(dead_code, unused_imports, unused_variables)]
use super::{ use super::{
settings_page::{ settings_page::{
render_page_title, MatchData, PageType, SettingsPageMeta, SettingsPageViewHandle, render_page_title, MatchData, PageType, SettingsPageMeta, SettingsPageViewHandle,
+1
View File
@@ -1,3 +1,4 @@
#![allow(dead_code, unused_imports, unused_variables)]
use super::admin_actions::AdminActions; use super::admin_actions::AdminActions;
use super::settings_page::{render_customer_type_badge, MatchData, PageType, SettingsWidget}; use super::settings_page::{render_customer_type_badge, MatchData, PageType, SettingsWidget};
use super::transfer_ownership_confirmation_modal::{ use super::transfer_ownership_confirmation_modal::{
+1
View File
@@ -5,6 +5,7 @@ use galaxy_core::telemetry::{EnablementState, TelemetryEvent, TelemetryEventDesc
#[derive(Debug, EnumDiscriminants)] #[derive(Debug, EnumDiscriminants)]
#[strum_discriminants(derive(EnumIter))] #[strum_discriminants(derive(EnumIter))]
#[allow(dead_code)]
pub enum SettingsTelemetryEvent { pub enum SettingsTelemetryEvent {
EnvironmentsPageOpened, EnvironmentsPageOpened,
} }
@@ -1,3 +1,4 @@
#![allow(dead_code, unused_imports, unused_variables)]
use galaxyui::{ use galaxyui::{
elements::{Align, Container, CrossAxisAlignment, Flex, MouseStateHandle, ParentElement, Text}, elements::{Align, Container, CrossAxisAlignment, Flex, MouseStateHandle, ParentElement, Text},
ui_components::{ ui_components::{
@@ -45,6 +45,7 @@ pub enum TerminalViewZeroStateAction {
} }
#[derive(Default)] #[derive(Default)]
#[allow(dead_code)]
struct StateHandles { struct StateHandles {
dismiss_button: MouseStateHandle, dismiss_button: MouseStateHandle,
start_new_conversation: MouseStateHandle, start_new_conversation: MouseStateHandle,
@@ -1,3 +1,4 @@
#![allow(dead_code, unused_imports, unused_variables)]
use crate::{ use crate::{
appearance::Appearance, appearance::Appearance,
editor::{EditorOptions, EditorView, Event as EditorEvent, TextOptions}, editor::{EditorOptions, EditorView, Event as EditorEvent, TextOptions},
+1
View File
@@ -1,3 +1,4 @@
#![allow(dead_code, unused_imports, unused_variables)]
use pathfinder_color::ColorU; use pathfinder_color::ColorU;
use galaxy_editor::editor::NavigationKey; use galaxy_editor::editor::NavigationKey;
use galaxyui::{ use galaxyui::{
+1
View File
@@ -18,6 +18,7 @@ pub struct PaneViewLocator {
} }
#[derive(Default)] #[derive(Default)]
#[allow(dead_code)]
pub(super) struct WorkspaceMouseStates { pub(super) struct WorkspaceMouseStates {
pub(super) new_tab_button: MouseStateHandle, pub(super) new_tab_button: MouseStateHandle,
pub(super) new_tab_menu: MouseStateHandle, pub(super) new_tab_menu: MouseStateHandle,
+1
View File
@@ -17650,6 +17650,7 @@ impl Workspace {
.finish() .finish()
} }
#[allow(dead_code)]
fn render_avatar_button(&self, appearance: &Appearance, ctx: &AppContext) -> Box<dyn Element> { fn render_avatar_button(&self, appearance: &Appearance, ctx: &AppContext) -> Box<dyn Element> {
let is_anonymous = self.auth_state.is_anonymous_or_logged_out(); let is_anonymous = self.auth_state.is_anonymous_or_logged_out();
let display_name = self let display_name = self