public/galaxy
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix CI to work in the warpdotdev/warp repo. (#9226)

Browse Source 
## Description

A couple issues that needed fixing:
* Using `--all-features` and `--all-targets` causes us to try to build
the first-party binaries with embedded configuration, which isn't
available from this repository. To unblock CI, we'll only run clippy on
the default feature set for right now.
* Similarly, testing compilation with release configuration was trying
to build the `dev` channel; this switches that over to the `oss`
channel.
This commit is contained in:
David Stern
2026-04-28 11:34:34 -04:00
committed by GitHub
parent 0ca787cac3
commit 4a00689af9
7 changed files with 49 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
script/presubmit
+3 -1
View File
@@ -20,7 +20,9 @@ echo "Cargo fmt succeeded..."
echo "Running clippy..."
# Exclude warp_completer because we run clippy on it with default features (rather than all features) below.
cargo clippy --workspace --exclude warp_completer --all-targets --all-features --tests -- -D warnings
#
# TODO(vorporeal): Re-enable the `all-features` flag once we've fixed things.
cargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warnings
# Run clippy on warp_completer with default, rather than all features enabled, because there is
# feature-gated logic for the WIP completions-on-js implementation.
cargo clippy -p warp_completer --all-targets --tests -- -D warnings