Fix View Options popup not responding to clicks

Remove duplicate popup rendering from render_vertical_tabs_panel.
The popup was rendered both inside the panel's stack AND at the
workspace level in a Dismiss overlay, causing event dispatch conflicts
due to shared MouseStateHandle instances between the two identical
popup trees.
This commit is contained in:
Ryan Ward
2026-06-23 15:28:59 -05:00
parent 5ea378a38d
commit 148c97eab1
49 changed files with 1507 additions and 419 deletions
@@ -1,7 +1,7 @@
pub use crate::util::openable_file_type::EditorLayout;
use serde::{Deserialize, Deserializer, Serialize};
use settings::{
macros::define_settings_group, RespectUserSyncSetting, SupportedPlatforms, SyncToCloud,
macros::define_settings_group, SupportedPlatforms, SyncToCloud,
};
#[derive(
@@ -92,7 +92,7 @@ define_settings_group!(EditorSettings, settings: [
type: EditorLayout,
default: EditorLayout::SplitPane,
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "code.editor.open_file_layout",
description: "The layout used when opening files in the editor.",
@@ -101,7 +101,7 @@ define_settings_group!(EditorSettings, settings: [
type: bool,
default: true,
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "code.editor.prefer_markdown_viewer",
description: "Whether to use the Markdown viewer when opening Markdown files.",
@@ -110,7 +110,7 @@ define_settings_group!(EditorSettings, settings: [
type: bool,
default: true,
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "code.editor.prefer_tabbed_editor_view",
description: "Whether to prefer opening files in a tabbed editor view.",
@@ -119,7 +119,7 @@ define_settings_group!(EditorSettings, settings: [
type: OpenConversationPreference,
default: OpenConversationPreference::NewTab,
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "agents.warp_agent.other.open_conversation_layout_preference",
description: "Whether to open agent conversations in a new tab or a split pane.",