Fix View Options popup not responding to clicks

Remove duplicate popup rendering from render_vertical_tabs_panel.
The popup was rendered both inside the panel's stack AND at the
workspace level in a Dismiss overlay, causing event dispatch conflicts
due to shared MouseStateHandle instances between the two identical
popup trees.
This commit is contained in:
Ryan Ward
2026-06-23 15:28:59 -05:00
parent 5ea378a38d
commit 148c97eab1
49 changed files with 1507 additions and 419 deletions
+6 -6
View File
@@ -3,7 +3,7 @@ use serde::{Deserialize, Serialize};
use crate::settings::{AISettings, InputSettings, TerminalSpacing};
use galaxyui::{units::Pixels, AppContext, SingletonEntity};
use settings::{
macros::define_settings_group, RespectUserSyncSetting, SupportedPlatforms, SyncToCloud,
macros::define_settings_group, SupportedPlatforms, SyncToCloud,
};
#[derive(
@@ -89,7 +89,7 @@ define_settings_group!(TerminalSettings, settings: [
type: bool,
default: false,
supported_platforms: SupportedPlatforms::DESKTOP, /* Audible bell is not supported on web */
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "terminal.use_audible_bell",
description: "Whether to play an audible bell sound on terminal bell events.",
@@ -98,7 +98,7 @@ define_settings_group!(TerminalSettings, settings: [
type: SpacingMode,
default: SpacingMode::default(),
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "appearance.spacing",
description: "Controls the spacing between terminal blocks.",
@@ -107,7 +107,7 @@ define_settings_group!(TerminalSettings, settings: [
type: usize,
default: 50_000,
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "terminal.maximum_grid_size",
description: "The maximum number of rows in the terminal grid.",
@@ -116,7 +116,7 @@ define_settings_group!(TerminalSettings, settings: [
type: AltScreenPaddingMode,
default: AltScreenPaddingMode::default(),
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "appearance.full_screen_apps.alt_screen_padding",
max_table_depth: 0,
@@ -128,7 +128,7 @@ define_settings_group!(TerminalSettings, settings: [
type: bool,
default: true,
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "terminal.show_terminal_zero_state_block",
description: "Whether to show the AI zero-state block in new terminal sessions.",