Fix View Options popup not responding to clicks

Remove duplicate popup rendering from render_vertical_tabs_panel.
The popup was rendered both inside the panel's stack AND at the
workspace level in a Dismiss overlay, causing event dispatch conflicts
due to shared MouseStateHandle instances between the two identical
popup trees.
This commit is contained in:
Ryan Ward
2026-06-23 15:28:59 -05:00
parent 5ea378a38d
commit 148c97eab1
49 changed files with 1507 additions and 419 deletions
+12 -12
View File
@@ -10,7 +10,7 @@ pub use startup_shell::*;
pub use working_directory_config::*;
use galaxy_core::settings::{
macros::define_settings_group, RespectUserSyncSetting, SupportedPlatforms, SyncToCloud,
macros::define_settings_group, SupportedPlatforms, SyncToCloud,
};
use crate::ai::blocklist::agent_view::toolbar_item::AgentToolbarItemKind;
@@ -300,7 +300,7 @@ define_settings_group!(SessionSettings, settings: [
type: bool,
default: false,
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "terminal.input.honor_ps1",
description: "Whether to use your shell's PS1 prompt instead of the Galaxy prompt.",
@@ -309,21 +309,21 @@ define_settings_group!(SessionSettings, settings: [
type: PromptSelection,
default: PromptSelection::default(),
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: true,
},
should_add_agent_mode_chip: ShouldAddAgentModeChip {
type: bool,
default: true,
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: true,
},
should_confirm_close_session: ShouldConfirmCloseSession {
type: bool,
default: true,
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "general.should_confirm_close_session",
description: "Whether to show a confirmation dialog when closing a session.",
@@ -333,14 +333,14 @@ define_settings_group!(SessionSettings, settings: [
type: bool,
default: true,
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: true,
}
notifications: Notifications {
type: NotificationsSettings,
default: NotificationsSettings::default(),
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "notifications.preferences",
max_table_depth: 1,
@@ -353,7 +353,7 @@ define_settings_group!(SessionSettings, settings: [
type: bool,
default: true,
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: true,
storage_key: "GitPromptDirtyIndicator",
},
@@ -364,7 +364,7 @@ define_settings_group!(SessionSettings, settings: [
type: bool,
default: true,
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "agents.warp_agent.input.show_model_selectors_in_prompt",
description: "Whether to show AI model selectors in the input prompt.",
@@ -373,7 +373,7 @@ define_settings_group!(SessionSettings, settings: [
type: AgentToolbarChipSelection,
default: AgentToolbarChipSelection::default(),
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "agents.warp_agent.input.agent_toolbar_chip_selection_setting",
description: "Controls the layout of context chips in the Agent Mode toolbar.",
@@ -382,7 +382,7 @@ define_settings_group!(SessionSettings, settings: [
type: CLIAgentToolbarChipSelection,
default: CLIAgentToolbarChipSelection::default(),
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "agents.third_party.cli_agent_toolbar_chip_selection_setting",
description: "Controls the layout of context chips in the CLI Agent toolbar.",
@@ -391,7 +391,7 @@ define_settings_group!(SessionSettings, settings: [
type: u64,
default: 8,
supported_platforms: SupportedPlatforms::ALL,
sync_to_cloud: SyncToCloud::Globally(RespectUserSyncSetting::Yes),
sync_to_cloud: SyncToCloud::Never,
private: false,
toml_path: "notifications.toast_duration_secs",
description: "How long notification toasts are displayed, in seconds.",